Re: [RESEND PATCH 05/12] golang/xenlight: use struct pointers in keyed union fields

2021-06-18 Thread George Dunlap
> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > > Currently, when marshalig Go types with keyed union fields, we assign the > value of the struct (e.g. DomainBuildInfoTypeUnionHvm) which implements the > interface of the keyed union field (e.g. DomainBuildInfoTypeUnion). > As-is, this me

[RESEND PATCH 05/12] golang/xenlight: use struct pointers in keyed union fields

2021-05-24 Thread Nick Rosbrook
Currently, when marshalig Go types with keyed union fields, we assign the value of the struct (e.g. DomainBuildInfoTypeUnionHvm) which implements the interface of the keyed union field (e.g. DomainBuildInfoTypeUnion). As-is, this means that if a populated DomainBuildInfo is marshaled to e.g. JSON,

[PATCH 05/12] golang/xenlight: use struct pointers in keyed union fields

2021-04-28 Thread Nick Rosbrook
Currently, when marshalig Go types with keyed union fields, we assign the value of the struct (e.g. DomainBuildInfoTypeUnionHvm) which implements the interface of the keyed union field (e.g. DomainBuildInfoTypeUnion). As-is, this means that if a populated DomainBuildInfo is marshaled to e.g. JSON,