Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode

2021-12-13 Thread Samuel Thibault
Juergen Gross, le mar. 14 déc. 2021 07:35:54 +0100, a ecrit: > On 13.12.21 22:22, Samuel Thibault wrote: > > Juergen Gross, le lun. 13 déc. 2021 15:58:58 +0100, a ecrit: > > > On 12.12.21 01:15, Samuel Thibault wrote: > > > > Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit: > > > > > -

Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode

2021-12-13 Thread Juergen Gross
On 13.12.21 22:22, Samuel Thibault wrote: Juergen Gross, le lun. 13 déc. 2021 15:58:58 +0100, a ecrit: On 12.12.21 01:15, Samuel Thibault wrote: Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit: -unsigned long pfn, max = 0; +unsigned long pfns, max = 0; I'd say rather rena

Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode

2021-12-13 Thread Samuel Thibault
Juergen Gross, le lun. 13 déc. 2021 15:58:58 +0100, a ecrit: > On 12.12.21 01:15, Samuel Thibault wrote: > > Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit: > > > -unsigned long pfn, max = 0; > > > +unsigned long pfns, max = 0; > > > > I'd say rather rename max to start. > >

Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode

2021-12-13 Thread Juergen Gross
On 12.12.21 01:15, Samuel Thibault wrote: Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit: -unsigned long pfn, max = 0; +unsigned long pfns, max = 0; I'd say rather rename max to start. e820_get_memmap(); @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)

Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode

2021-12-11 Thread Samuel Thibault
Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit: > -unsigned long pfn, max = 0; > +unsigned long pfns, max = 0; I'd say rather rename max to start. > e820_get_memmap(); > > @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void) > { > if ( e820_map[i].typ

[PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode

2021-12-05 Thread Juergen Gross
Sizing the available memory should respect memory holes, so look at the memory map when setting the boundary for the memory allocator. Signed-off-by: Juergen Gross --- arch/x86/mm.c | 6 +- e820.c | 13 - include/e820.h | 2 +- 3 files changed, 10 insertions(+), 11 del