Re: [PATCH 01/16] iommu: Add checks before calling iommu suspend/resume

2025-03-11 Thread Julien Grall
Hi, On 05/03/2025 09:11, Mykola Kvach wrote: From: Mykyta Poturai These functions may be unimplemented, so check that they exist before calling to prevent crashes. Looking at the cover letter, I see you wrote the following: "Add suspend/resume handlers to IOMMU drivers (there aren’t any pro

Re: [PATCH 01/16] iommu: Add checks before calling iommu suspend/resume

2025-03-05 Thread Jan Beulich
On 05.03.2025 10:11, Mykola Kvach wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -613,7 +613,7 @@ int __init iommu_setup(void) > > int iommu_suspend(void) > { > -if ( iommu_enabled ) > +if ( iommu_enabled && iommu_get_ops() && iommu_get_ops()

[PATCH 01/16] iommu: Add checks before calling iommu suspend/resume

2025-03-05 Thread Mykola Kvach
From: Mykyta Poturai These functions may be unimplemented, so check that they exist before calling to prevent crashes. Signed-off-by: Mykyta Poturai Signed-off-by: Mykola Kvach --- Introduced in patch series V3. --- xen/drivers/passthrough/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2