Re: [PATCH 0.5/2] x86/boot: Clean up early error asm

2023-06-19 Thread Jan Beulich
On 19.06.2023 13:20, Andrew Cooper wrote: > On 19/06/2023 9:10 am, Jan Beulich wrote: >> On 16.06.2023 20:23, Andrew Cooper wrote: >>> The asm forming early error handling is a mix of local and non-local >>> symbols, >>> and has some pointless comments. Drop the "# Error message" comments, >>> tw

Re: [PATCH 0.5/2] x86/boot: Clean up early error asm

2023-06-19 Thread Andrew Cooper
On 19/06/2023 9:10 am, Jan Beulich wrote: > On 16.06.2023 20:23, Andrew Cooper wrote: >> The asm forming early error handling is a mix of local and non-local symbols, >> and has some pointless comments. Drop the "# Error message" comments, >> tweaking the style on modified lines, and make the symb

Re: [PATCH 0.5/2] x86/boot: Clean up early error asm

2023-06-19 Thread Jan Beulich
On 16.06.2023 20:23, Andrew Cooper wrote: > The asm forming early error handling is a mix of local and non-local symbols, > and has some pointless comments. Drop the "# Error message" comments, > tweaking the style on modified lines, and make the symbols local. > > However, leave behind one real

[PATCH 0.5/2] x86/boot: Clean up early error asm

2023-06-16 Thread Andrew Cooper
The asm forming early error handling is a mix of local and non-local symbols, and has some pointless comments. Drop the "# Error message" comments, tweaking the style on modified lines, and make the symbols local. However, leave behind one real symbol so this logic disassembles nicely without mer