Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-25 Thread Jürgen Groß
On 25.08.20 10:58, Thomas Gleixner wrote: On Mon, Aug 24 2020 at 20:14, Stefano Stabellini wrote: On Fri, 21 Aug 2020, Thomas Gleixner wrote: are accessors to handler_data. Am I missing something? I think Juergen's suggestion was to use function pointers as accessors. The underlying problem i

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-25 Thread Thomas Gleixner
On Mon, Aug 24 2020 at 20:14, Stefano Stabellini wrote: > On Fri, 21 Aug 2020, Thomas Gleixner wrote: >> are accessors to handler_data. Am I missing something? > I think Juergen's suggestion was to use function pointers as accessors. > > The underlying problem is that both Xen and GPIO want to use

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-24 Thread Stefano Stabellini
On Fri, 21 Aug 2020, Thomas Gleixner wrote: > On Fri, Aug 21 2020 at 14:17, Jürgen Groß wrote: > > On 21.08.20 13:19, Sergei Temerkhanov wrote: > >>> Did you see any specific problem where handler_data is written by > >> another component? > >> > >> I've posted this series in the thread > >> https

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Thomas Gleixner
On Fri, Aug 21 2020 at 23:38, Sergei Temerkhanov wrote: > On Fri, Aug 21, 2020 at 11:07 PM Thomas Gleixner wrote: >> Fiddling in irqchip is wrong to begin with. >> >> int irq_set_handler_data(unsigned int irq, void *data); >> static inline void *irq_get_handler_data(unsigned int irq) >> static inl

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Sergei Temerkhanov
On Fri, Aug 21, 2020 at 11:07 PM Thomas Gleixner wrote: > Fiddling in irqchip is wrong to begin with. > > int irq_set_handler_data(unsigned int irq, void *data); > static inline void *irq_get_handler_data(unsigned int irq) > static inline void *irq_data_get_irq_handler_data(struct irq_data *d) > >

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Thomas Gleixner
On Fri, Aug 21 2020 at 14:17, Jürgen Groß wrote: > On 21.08.20 13:19, Sergei Temerkhanov wrote: >>> Did you see any specific problem where handler_data is written by >> another component? >> >> I've posted this series in the thread >> https://lists.xenproject.org/archives/html/xen-devel/2020-08/ms

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Jürgen Groß
On 21.08.20 13:19, Sergei Temerkhanov wrote: Did you see any specific problem where handler_data is written by another component? I've posted this series in the thread https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00957.html where the problem is caused exactly by that behavior

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Sergei Temerkhanov
>Did you see any specific problem where handler_data is written by another component? I've posted this series in the thread https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00957.html where the problem is caused exactly by that behavior >In case this is a real problem I don't think

Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Jürgen Groß
On 21.08.20 09:15, Sergey Temerkhanov wrote: Use a dedicated pointer for IRQ data to avoid conflicts with some other parts of the kernel code which my use handler_data for their own purposes while still running on Xen Sergey Temerkhanov (2): Xen: Use a dedicated irq_info structure pointer

[PATCH 0/2] Xen: Use a dedicated pointer for IRQ data

2020-08-21 Thread Sergey Temerkhanov
Use a dedicated pointer for IRQ data to avoid conflicts with some other parts of the kernel code which my use handler_data for their own purposes while still running on Xen Sergey Temerkhanov (2): Xen: Use a dedicated irq_info structure pointer Xen: Rename irq_info structure drivers/xen/even