Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Juergen Gross
On 24.08.22 13:12, Jan Beulich wrote: On 24.08.2022 12:45, Juergen Gross wrote: On 24.08.22 12:35, Jan Beulich wrote: On 24.08.2022 12:22, Juergen Gross wrote: Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production builds a warning seems to be appropriate when hitting one. I

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Andrew Cooper
On 24/08/2022 11:35, Jan Beulich wrote: > On 24.08.2022 12:22, Juergen Gross wrote: >> Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production >> builds a warning seems to be appropriate when hitting one. > I disagree, for two reasons: This violates the implication of NDEBUG > meanin

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Jan Beulich
On 24.08.2022 12:45, Juergen Gross wrote: > On 24.08.22 12:35, Jan Beulich wrote: >> On 24.08.2022 12:22, Juergen Gross wrote: >>> Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production >>> builds a warning seems to be appropriate when hitting one. >> >> I disagree, for two reasons:

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Juergen Gross
On 24.08.22 12:35, Jan Beulich wrote: On 24.08.2022 12:22, Juergen Gross wrote: Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production builds a warning seems to be appropriate when hitting one. I disagree, for two reasons: This violates the implication of NDEBUG meaning ASSERT(

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Bertrand Marquis
Hi, > On 24 Aug 2022, at 11:35, Jan Beulich wrote: > > On 24.08.2022 12:22, Juergen Gross wrote: >> Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production >> builds a warning seems to be appropriate when hitting one. > > I disagree, for two reasons: This violates the implication

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Jan Beulich
On 24.08.2022 12:22, Juergen Gross wrote: > Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production > builds a warning seems to be appropriate when hitting one. I disagree, for two reasons: This violates the implication of NDEBUG meaning ASSERT() and friends expand to no actual code

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Julien Grall
Hi Juergen, Thanks for sending the patch quickly :). On 24/08/2022 11:22, Juergen Gross wrote: Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production builds a warning seems to be appropriate when hitting one. In order not to flood the console in reproducible cases, introduce WA

[PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

2022-08-24 Thread Juergen Gross
Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production builds a warning seems to be appropriate when hitting one. In order not to flood the console in reproducible cases, introduce WARN_ONCE() to be used in this case. Signed-off-by: Juergen Gross --- Notice for the release manage