Re: [PATCH] xen: fix memory leak on error in vcpu_create

2025-07-29 Thread Andrew Cooper
On 29/07/2025 10:08 pm, Stewart Hildebrand wrote: > On 7/29/25 04:32, Jan Beulich wrote: >> On 28.07.2025 22:09, Andrew Cooper wrote: >>> On 28/07/2025 8:52 pm, Stewart Hildebrand wrote: In vcpu_create after scheduler data is allocated, if vmtrace_alloc_buffer fails, it will jump to the w

Re: [PATCH] xen: fix memory leak on error in vcpu_create

2025-07-29 Thread Stewart Hildebrand
On 7/29/25 04:32, Jan Beulich wrote: > On 28.07.2025 22:09, Andrew Cooper wrote: >> On 28/07/2025 8:52 pm, Stewart Hildebrand wrote: >>> In vcpu_create after scheduler data is allocated, if >>> vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label >>> resulting in a memory leak. Corre

Re: [PATCH] xen: fix memory leak on error in vcpu_create

2025-07-29 Thread Jan Beulich
On 28.07.2025 22:09, Andrew Cooper wrote: > On 28/07/2025 8:52 pm, Stewart Hildebrand wrote: >> In vcpu_create after scheduler data is allocated, if >> vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label >> resulting in a memory leak. Correct the label. >> >> Fixes: 217dd79ee292 ("x

Re: [PATCH] xen: fix memory leak on error in vcpu_create

2025-07-29 Thread Jan Beulich
On 28.07.2025 22:12, Andrew Cooper wrote: > On 28/07/2025 9:09 pm, Andrew Cooper wrote: >> On 28/07/2025 8:52 pm, Stewart Hildebrand wrote: >>> In vcpu_create after scheduler data is allocated, if >>> vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label >>> resulting in a memory leak

Re: [PATCH] xen: fix memory leak on error in vcpu_create

2025-07-28 Thread Andrew Cooper
On 28/07/2025 9:09 pm, Andrew Cooper wrote: > On 28/07/2025 8:52 pm, Stewart Hildebrand wrote: >> In vcpu_create after scheduler data is allocated, if >> vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label >> resulting in a memory leak. Correct the label. >> >> Fixes: 217dd79ee292 (

Re: [PATCH] xen: fix memory leak on error in vcpu_create

2025-07-28 Thread Andrew Cooper
On 28/07/2025 8:52 pm, Stewart Hildebrand wrote: > In vcpu_create after scheduler data is allocated, if > vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label > resulting in a memory leak. Correct the label. > > Fixes: 217dd79ee292 ("xen/domain: Add vmtrace_size domain creation param

[PATCH] xen: fix memory leak on error in vcpu_create

2025-07-28 Thread Stewart Hildebrand
In vcpu_create after scheduler data is allocated, if vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label resulting in a memory leak. Correct the label. Fixes: 217dd79ee292 ("xen/domain: Add vmtrace_size domain creation parameter") Signed-off-by: Stewart Hildebrand --- xen/common/