Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-15 Thread Julien Grall
Hi, On 14/06/2023 10:09, Julien Grall wrote: The patch looks fine. I will commit it a bit later just to give a chance to Bertrand/Stefano to object. And committed. Cheers, -- Julien Grall

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Bertrand Marquis
Hi Michal, > On 14 Jun 2023, at 09:30, Michal Orzel wrote: > > Missing newline is inconsistent with the rest of the callers, since > panic() expects it. > > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis And I agree with Julien: trailing punctuation is not an issue and I would def

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Julien Grall
On 14/06/2023 10:06, Michal Orzel wrote: On 14/06/2023 11:02, Julien Grall wrote: On 14/06/2023 09:09, Michal Orzel wrote: On 14/06/2023 10:04, Andrew Cooper wrote: On 14/06/2023 8:30 am, Michal Orzel wrote: Missing newline is inconsistent with the rest of the callers, since panic(

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Michal Orzel
On 14/06/2023 11:02, Julien Grall wrote: > > > On 14/06/2023 09:09, Michal Orzel wrote: >> >> >> On 14/06/2023 10:04, Andrew Cooper wrote: >>> >>> >>> On 14/06/2023 8:30 am, Michal Orzel wrote: Missing newline is inconsistent with the rest of the callers, since panic() expects it. >>

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Julien Grall
On 14/06/2023 09:09, Michal Orzel wrote: On 14/06/2023 10:04, Andrew Cooper wrote: On 14/06/2023 8:30 am, Michal Orzel wrote: Missing newline is inconsistent with the rest of the callers, since panic() expects it. Signed-off-by: Michal Orzel Acked-by: Andrew Cooper although... --

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Michal Orzel
On 14/06/2023 10:04, Andrew Cooper wrote: > > > On 14/06/2023 8:30 am, Michal Orzel wrote: >> Missing newline is inconsistent with the rest of the callers, since >> panic() expects it. >> >> Signed-off-by: Michal Orzel > > Acked-by: Andrew Cooper > > although... > >> --- >> xen/arch/arm/

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Andrew Cooper
On 14/06/2023 8:30 am, Michal Orzel wrote: > Missing newline is inconsistent with the rest of the callers, since > panic() expects it. > > Signed-off-by: Michal Orzel Acked-by: Andrew Cooper although... > --- > xen/arch/arm/bootfdt.c| 2 +- > xen/arch/arm/domain_build.c | 6

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Jan Beulich
On 14.06.2023 09:45, Luca Fancellu wrote: >> On 14 Jun 2023, at 08:30, Michal Orzel wrote: >> >> Missing newline is inconsistent with the rest of the callers, since >> panic() expects it. >> >> Signed-off-by: Michal Orzel > > Reviewed-by: Luca Fancellu Acked-by: Jan Beulich

Re: [PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Luca Fancellu
> On 14 Jun 2023, at 08:30, Michal Orzel wrote: > > Missing newline is inconsistent with the rest of the callers, since > panic() expects it. > > Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu > --- > xen/arch/arm/bootfdt.c| 2 +- > xen/arch/arm/domain_build.c | 6

[PATCH] xen: Append a newline character to panic() where missing

2023-06-14 Thread Michal Orzel
Missing newline is inconsistent with the rest of the callers, since panic() expects it. Signed-off-by: Michal Orzel --- xen/arch/arm/bootfdt.c| 2 +- xen/arch/arm/domain_build.c | 6 +++--- xen/arch/x86/cpu/microcode/core.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(