Re: [PATCH] xen/xenbus: Fix a double free in xenbus_map_ring_pv()

2020-07-10 Thread Boris Ostrovsky
On 7/10/20 8:15 AM, Jürgen Groß wrote: > On 10.07.20 13:36, Dan Carpenter wrote: >> When there is an error the caller frees "info->node" so the free here >> will result in a double free.  We should just delete first kfree(). >> >> Fixes: 3848e4e0a32a ("xen/xenbus: avoid large structs and arrays on

Re: [PATCH] xen/xenbus: Fix a double free in xenbus_map_ring_pv()

2020-07-10 Thread Jürgen Groß
On 10.07.20 13:36, Dan Carpenter wrote: When there is an error the caller frees "info->node" so the free here will result in a double free. We should just delete first kfree(). Fixes: 3848e4e0a32a ("xen/xenbus: avoid large structs and arrays on the stack") Signed-off-by: Dan Carpenter Thanks

[PATCH] xen/xenbus: Fix a double free in xenbus_map_ring_pv()

2020-07-10 Thread Dan Carpenter
When there is an error the caller frees "info->node" so the free here will result in a double free. We should just delete first kfree(). Fixes: 3848e4e0a32a ("xen/xenbus: avoid large structs and arrays on the stack") Signed-off-by: Dan Carpenter --- drivers/xen/xenbus/xenbus_client.c | 4 +---