Re: [PATCH] xen/rwlock: Don't perpeuatite broken API in new logic

2024-03-20 Thread Julien Grall
On 20/03/2024 06:35, Jürgen Groß wrote: On 19.03.24 12:30, Andrew Cooper wrote: The single user wants this the sane way around.  Write it as a normal static inline just like rspin_lock(). Fixes: cc3e8df542ed ("xen/spinlock: add rspin_[un]lock_irq[save|restore]()") Signed-off-by: Andrew Co

Re: [PATCH] xen/rwlock: Don't perpeuatite broken API in new logic

2024-03-20 Thread Jan Beulich
On 19.03.2024 12:30, Andrew Cooper wrote: > The single user wants this the sane way around. Write it as a normal static > inline just like rspin_lock(). > > Fixes: cc3e8df542ed ("xen/spinlock: add rspin_[un]lock_irq[save|restore]()") > Signed-off-by: Andrew Cooper Notwithstanding Jürgen's R-b I

Re: [PATCH] xen/rwlock: Don't perpeuatite broken API in new logic

2024-03-19 Thread Jürgen Groß
On 19.03.24 12:30, Andrew Cooper wrote: The single user wants this the sane way around. Write it as a normal static inline just like rspin_lock(). Fixes: cc3e8df542ed ("xen/spinlock: add rspin_[un]lock_irq[save|restore]()") Signed-off-by: Andrew Cooper Reviewed-by: Juergen Gross Maybe with

[PATCH] xen/rwlock: Don't perpeuatite broken API in new logic

2024-03-19 Thread Andrew Cooper
The single user wants this the sane way around. Write it as a normal static inline just like rspin_lock(). Fixes: cc3e8df542ed ("xen/spinlock: add rspin_[un]lock_irq[save|restore]()") Signed-off-by: Andrew Cooper --- CC: Juergen Gross CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini