Re: [PATCH] xen/decompress: make helper symbols static

2021-01-19 Thread Jan Beulich
On 19.01.2021 15:58, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] xen/decompress: make helper symbols static"): >> On 18.01.2021 17:09, Ian Jackson wrote: >>> AFAICT, this patch >>> >>> * was first posted after the last posting date for Xen

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-19 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] xen/decompress: make helper symbols static"): > On 18.01.2021 17:09, Ian Jackson wrote: > > AFAICT, this patch > > > > * was first posted after the last posting date for Xen 4.15. > > * is not a bugfix. > > > >

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
On 18.01.2021 17:09, Ian Jackson wrote: > Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"): >> The individual decompression CUs need to only surface their top level >> functions to other code. Arrange for everything else to be static, to >>

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Andrew Cooper
On 18/01/2021 16:09, Ian Jackson wrote: > Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"): >> The individual decompression CUs need to only surface their top level >> functions to other code. Arrange for everything else to be static, to >>

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Ian Jackson
Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"): > The individual decompression CUs need to only surface their top level > functions to other code. Arrange for everything else to be static, to > make sure no undue uses of that code exist or

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
On 18.01.2021 16:31, Andrew Cooper wrote: > On 18/01/2021 15:13, Jan Beulich wrote: >> On 18.01.2021 12:58, Andrew Cooper wrote: >>> but I really would >>> like to see the STATIC and INIT defines disappear eventually. >> I too would like to, but I don't see this happen in particular >> for INIT and

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Andrew Cooper
On 18/01/2021 15:13, Jan Beulich wrote: > On 18.01.2021 12:58, Andrew Cooper wrote: >> On 18/01/2021 11:19, Jan Beulich wrote: >>> The individual decompression CUs need to only surface their top level >>> functions to other code. Arrange for everything else to be static, to >>> make sure no undue u

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
On 18.01.2021 12:58, Andrew Cooper wrote: > On 18/01/2021 11:19, Jan Beulich wrote: >> The individual decompression CUs need to only surface their top level >> functions to other code. Arrange for everything else to be static, to >> make sure no undue uses of that code exist or will appear without

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Andrew Cooper
On 18/01/2021 11:19, Jan Beulich wrote: > The individual decompression CUs need to only surface their top level > functions to other code. Arrange for everything else to be static, to > make sure no undue uses of that code exist or will appear without > explicitly noticing. (In some cases this also

[PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
The individual decompression CUs need to only surface their top level functions to other code. Arrange for everything else to be static, to make sure no undue uses of that code exist or will appear without explicitly noticing. (In some cases this also results in code size reduction, but since this