Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-26 Thread Jan Beulich
On 26.02.2025 19:39, Denis Mukhin wrote: > On Wednesday, February 26th, 2025 at 3:30 AM, Jan Beulich > wrote: > >> >> >> On 18.02.2025 09:31, dm...@proton.me wrote: >> >>> From: Denis Mukhin dmuk...@ford.com >>> >>> console_input_domain() takes an RCU lock to protect domain structure. >>> That i

Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-26 Thread Denis Mukhin
On Wednesday, February 26th, 2025 at 3:30 AM, Jan Beulich wrote: > > > On 18.02.2025 09:31, dm...@proton.me wrote: > > > From: Denis Mukhin dmuk...@ford.com > > > > console_input_domain() takes an RCU lock to protect domain structure. > > That implies call to rcu_unlock_domain() after use. >

Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-26 Thread Jan Beulich
On 18.02.2025 09:31, dm...@proton.me wrote: > From: Denis Mukhin > > console_input_domain() takes an RCU lock to protect domain structure. > That implies call to rcu_unlock_domain() after use. > > Introduce a pair of console_get_domain() / console_put_domain() to highlight > the correct use of t

Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-21 Thread Denis Mukhin
On Wednesday, February 19th, 2025 at 5:52 AM, Jan Beulich wrote: > > > On 18.02.2025 09:31, dm...@proton.me wrote: > > > @@ -546,31 +555,23 @@ static void __serial_rx(char c) > > * getting stuck. > > */ > > send_global_virq(VIRQ_CONSOLE); > > - break; > > - > > + } > > #ifdef CONFIG_SBSA_VUAR

Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-21 Thread Denis Mukhin
On Friday, February 21st, 2025 at 4:04 PM, Stefano Stabellini wrote: > > > On Wed, 19 Feb 2025, Jan Beulich wrote: > > > On 18.02.2025 09:31, dm...@proton.me wrote: > > > > > @@ -546,31 +555,23 @@ static void __serial_rx(char c) > > > * getting stuck. > > > */ > > > send_global_virq(VIRQ_CON

Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-21 Thread Stefano Stabellini
On Wed, 19 Feb 2025, Jan Beulich wrote: > On 18.02.2025 09:31, dm...@proton.me wrote: > > @@ -546,31 +555,23 @@ static void __serial_rx(char c) > > * getting stuck. > > */ > > send_global_virq(VIRQ_CONSOLE); > > -break; > > - > > +} > > #ifdef CONFIG_SBSA_V

Re: [PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-19 Thread Jan Beulich
On 18.02.2025 09:31, dm...@proton.me wrote: > @@ -546,31 +555,23 @@ static void __serial_rx(char c) > * getting stuck. > */ > send_global_virq(VIRQ_CONSOLE); > -break; > - > +} > #ifdef CONFIG_SBSA_VUART_CONSOLE > -default: > -{ > -struct do

[PATCH] xen/console: introduce console_{get,put}_domain()

2025-02-18 Thread dmkhn
From: Denis Mukhin console_input_domain() takes an RCU lock to protect domain structure. That implies call to rcu_unlock_domain() after use. Introduce a pair of console_get_domain() / console_put_domain() to highlight the correct use of the call within the code interacting with Xen console drive