Re: [PATCH] xen/build: Fix build failure from LDFLAGS mismatch

2022-04-26 Thread Bertrand Marquis
Hi Andrew, > On 26 Apr 2022, at 00:06, Andrew Cooper wrote: > > In a GNU compatbile makefile, $(LDFLAGS) are passed to $(CC), not $(LD). You mean because CC is used for linking or even when compiling object files ? If not, what is the expected way to pass linker flags ? > > In a default Cent

Re: [PATCH] xen/build: Fix build failure from LDFLAGS mismatch

2022-04-26 Thread Jan Beulich
On 26.04.2022 01:06, Andrew Cooper wrote: > In a GNU compatbile makefile, $(LDFLAGS) are passed to $(CC), not $(LD). I have to admit that I have always been puzzled by this anomaly. > In a default CentOS 7 build environment, $(LDFLAGS) is set to -Wl,-z,relro, > which causes the Xen build to explo

[PATCH] xen/build: Fix build failure from LDFLAGS mismatch

2022-04-25 Thread Andrew Cooper
In a GNU compatbile makefile, $(LDFLAGS) are passed to $(CC), not $(LD). In a default CentOS 7 build environment, $(LDFLAGS) is set to -Wl,-z,relro, which causes the Xen build to explode with: ld: unrecognized option '-Wl,-z,relro' ld: use the --help option for usage information It turns out