Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-07-02 Thread Xenia Ragiadakou
On 6/29/22 18:02, Julien Grall wrote: On 29/06/2022 15:10, Bertrand Marquis wrote: Hi, Hi Bertrand, In fact the patch was committed before we started this discussion as Rahul R-b was enough. It was probably merged a bit too fast. When there are multiple maintainers responsible for the c

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Julien Grall
On 29/06/2022 15:10, Bertrand Marquis wrote: Hi, Hi Bertrand, In fact the patch was committed before we started this discussion as Rahul R-b was enough. It was probably merged a bit too fast. When there are multiple maintainers responsible for the code, I tend to prefer to wait a bit jus

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Bertrand Marquis
Hi, In fact the patch was committed before we started this discussion as Rahul R-b was enough. But I would still be interested to have other maintainers view on this. > On 29 Jun 2022, at 10:03, Bertrand Marquis wrote: > > Hi Xenia, > >> On 29 Jun 2022, at 09:55, xenia wrote: >> >> Hi Bertr

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Bertrand Marquis
Hi Xenia, > On 29 Jun 2022, at 09:55, xenia wrote: > > Hi Bertrand, > > On 6/29/22 10:24, Bertrand Marquis wrote: >> Hi Xenia, >> >>> On 28 Jun 2022, at 16:08, Xenia Ragiadakou wrote: >>> >>> The expression 1 << 31 produces undefined behaviour because the type of >>> integer >>> constant 1

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread xenia
Hi Bertrand, On 6/29/22 10:24, Bertrand Marquis wrote: Hi Xenia, On 28 Jun 2022, at 16:08, Xenia Ragiadakou wrote: The expression 1 << 31 produces undefined behaviour because the type of integer constant 1 is (signed) int and the result of shifting 1 by 31 bits is not representable in the (s

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Bertrand Marquis
Hi Xenia, > On 28 Jun 2022, at 16:08, Xenia Ragiadakou wrote: > > The expression 1 << 31 produces undefined behaviour because the type of > integer > constant 1 is (signed) int and the result of shifting 1 by 31 bits is not > representable in the (signed) int type. > Change the type of 1 to uns

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-28 Thread Rahul Singh
Hi Xenia, > On 28 Jun 2022, at 4:08 pm, Xenia Ragiadakou wrote: > > The expression 1 << 31 produces undefined behaviour because the type of > integer > constant 1 is (signed) int and the result of shifting 1 by 31 bits is not > representable in the (signed) int type. > Change the type of 1 to u

[PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-28 Thread Xenia Ragiadakou
The expression 1 << 31 produces undefined behaviour because the type of integer constant 1 is (signed) int and the result of shifting 1 by 31 bits is not representable in the (signed) int type. Change the type of 1 to unsigned int by adding the U suffix. Signed-off-by: Xenia Ragiadakou --- Q_OVER