Hi,
On 26/04/2022 16:37, Paran Lee wrote:
Thanks you, I agreed! It made me think once more about what my patch
could improve.
patches I sent have been reviewed in various ways. It was a good
opportunity to analyze my patch from various perspectives. :)
I checked objdump in -O2 optimization(defa
Hello, Julien Grall.
Thanks you, I agreed! It made me think once more about what my patch
could improve.
patches I sent have been reviewed in various ways. It was a good
opportunity to analyze my patch from various perspectives. :)
I checked objdump in -O2 optimization(default) of Xen Makefile to
Hi,
On 21/04/2022 16:17, Paran Lee wrote:
It doesn't seem necessary to do that calculation of order shift again.
I think we need to weight that against increasing the number of local
variables that do pretty much the same.
This is pretty much done to a matter of taste here. IMHO, the origin
On Fri, 22 Apr 2022, Paran Lee wrote:
> It doesn't seem necessary to do that calculation of order shift again.
>
> Signed-off-by: Paran Lee
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/arm/p2m.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/a
It doesn't seem necessary to do that calculation of order shift again.
Signed-off-by: Paran Lee
---
xen/arch/arm/p2m.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 1d1059f7d2..533afc830a 100644
--- a/xen/arch/arm/p2m.c