Re: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write

2023-11-23 Thread Julien Grall
On 23/11/2023 10:52, Julien Grall wrote: Hi Stewart, On 22/11/2023 14:46, Stewart Hildebrand wrote: GICD_CTL_ENABLE is a GICv2 bit. Remove it. The definitions of GICD_CTL_ENABLE and GICD_CTLR_ENABLE_G1 are identical, so the value written is unchanged. Thanks for spotting it. Maybe we shoul

Re: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write

2023-11-23 Thread Julien Grall
Hi Stewart, On 22/11/2023 14:46, Stewart Hildebrand wrote: GICD_CTL_ENABLE is a GICv2 bit. Remove it. The definitions of GICD_CTL_ENABLE and GICD_CTLR_ENABLE_G1 are identical, so the value written is unchanged. Thanks for spotting it. Maybe we should move GICv2 specific definitions out of gic

[PATCH] xen/arm: gicv3: clean up GICD_CTRL write

2023-11-22 Thread Stewart Hildebrand
GICD_CTL_ENABLE is a GICv2 bit. Remove it. The definitions of GICD_CTL_ENABLE and GICD_CTLR_ENABLE_G1 are identical, so the value written is unchanged. Signed-off-by: Stewart Hildebrand --- xen/arch/arm/gic-v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm