Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-19 Thread Julien Grall
Hi Andrew, On 14/02/2025 14:25, Andrew Cooper wrote: On 14/02/2025 2:10 pm, Grygorii Strashko wrote: For example, requested range:    00e614 - 00e6141004 should set e6140:e6141 nr=2, but will configure e6140 e6142 nr=3 instead. I am not sure what 'nr' is referring to here. Sorry, will

Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-18 Thread Grygorii Strashko
Hi Andrew, Julien, On 14.02.25 16:25, Andrew Cooper wrote: On 14/02/2025 2:10 pm, Grygorii Strashko wrote: For example, requested range:    00e614 - 00e6141004 should set e6140:e6141 nr=2, but will configure e6140 e6142 nr=3 instead. I am not sure what 'nr' is referring to here. Sorry

Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-14 Thread Andrew Cooper
On 14/02/2025 2:10 pm, Grygorii Strashko wrote: >>> >>> For example, requested range: >>>    00e614 - 00e6141004 should set e6140:e6141 nr=2, but will >>> configure >>> e6140 e6142 nr=3 instead. >> >> I am not sure what 'nr' is referring to here. > > Sorry, will change to "num_pages"? I agree

Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-14 Thread Grygorii Strashko
On 14.02.25 15:15, Julien Grall wrote: Hi, On 14/02/2025 12:55, Grygorii Strashko wrote: Now the following code in map_range_to_domain() res = iomem_permit_access(d, paddr_to_pfn(addr), paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); and res = rangeset_add_range(mr_data->iomem

Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-14 Thread Julien Grall
Hi, On 14/02/2025 12:55, Grygorii Strashko wrote: Now the following code in map_range_to_domain() res = iomem_permit_access(d, paddr_to_pfn(addr), paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); and res = rangeset_add_range(mr_data->iomem_ranges, paddr_to

[PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-14 Thread Grygorii Strashko
Now the following code in map_range_to_domain() res = iomem_permit_access(d, paddr_to_pfn(addr), paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); and res = rangeset_add_range(mr_data->iomem_ranges, paddr_to_pfn(addr), paddr_to_pfn_align