Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-29 Thread Michal Orzel
Hi Leo, On 28/09/2023 16:37, Leo Yan wrote: > > > Hi Michal, Julien, > > On Wed, Sep 27, 2023 at 02:49:23PM +0200, Michal Orzel wrote: > > [...] > >> Either way is fine. The advantage of placing the check in boot_fdt_info() is >> that we can have a single check instead of duplicated and we do

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-28 Thread Leo Yan
Hi Michal, Julien, On Wed, Sep 27, 2023 at 02:49:23PM +0200, Michal Orzel wrote: [...] > Either way is fine. The advantage of placing the check in boot_fdt_info() is > that we can have a single check instead of duplicated and we do the check > before > the "first" use which happens to be the ba

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-27 Thread Michal Orzel
Hi Julien, On 27/09/2023 13:01, Julien Grall wrote: > > > Hi Michal, > > On 26/09/2023 09:36, Michal Orzel wrote: >> On 26/09/2023 07:33, Leo Yan wrote: >>> >>> >>> During the Linux kernel booting, an error is reported by the Xen >>> hypervisor: >>> >>>(XEN) arch/arm/p2m.c:2202: d0v0: Faili

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-27 Thread Julien Grall
Hi Michal, On 26/09/2023 09:36, Michal Orzel wrote: On 26/09/2023 07:33, Leo Yan wrote: During the Linux kernel booting, an error is reported by the Xen hypervisor: (XEN) arch/arm/p2m.c:2202: d0v0: Failing to acquire the MFN 0x1a02dc The kernel attempts to use an invalid memory frame num

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-27 Thread Julien Grall
Hi Leo, Adding some comments on top of what already said. On 26/09/2023 06:33, Leo Yan wrote: +static bool __init memory_node_is_available(const void *fdt, unsigned long node) +{ +const char *status = fdt_getprop(fdt, node, "status", NULL); + +if (!status) +return true; + We

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Leo Yan
Hi Luca, On Tue, Sep 26, 2023 at 10:10:57AM +, Luca Fancellu wrote: [...] > >> I might be wrong, but reading the specifications seems that “status” is > >> not a property > >> of the child nodes of /reserved-memory, so I’m not sure Xen should do > >> something about it. > > > > Please take

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Leo Yan
Hi Michal, On Tue, Sep 26, 2023 at 10:36:04AM +0200, Michal Orzel wrote: [...] > > Essentially, this issue is caused by the Xen hypervisor which misses to > > handle the status for the memory nodes (for both the normal memory nodes > > and the reserved memory nodes) and transfers them to the Lin

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Luca Fancellu
> On 26 Sep 2023, at 11:04, Michal Orzel wrote: > > Hi Luca, > > On 26/09/2023 11:52, Luca Fancellu wrote: >> >> >>> On 26 Sep 2023, at 06:33, Leo Yan wrote: >>> >>> During the Linux kernel booting, an error is reported by the Xen >>> hypervisor: >>> >>> (XEN) arch/arm/p2m.c:2202: d0v0: F

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Michal Orzel
Hi Luca, On 26/09/2023 11:52, Luca Fancellu wrote: > > >> On 26 Sep 2023, at 06:33, Leo Yan wrote: >> >> During the Linux kernel booting, an error is reported by the Xen >> hypervisor: >> >> (XEN) arch/arm/p2m.c:2202: d0v0: Failing to acquire the MFN 0x1a02dc >> >> The kernel attempts to use a

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Luca Fancellu
> On 26 Sep 2023, at 06:33, Leo Yan wrote: > > During the Linux kernel booting, an error is reported by the Xen > hypervisor: > > (XEN) arch/arm/p2m.c:2202: d0v0: Failing to acquire the MFN 0x1a02dc > > The kernel attempts to use an invalid memory frame number, which can be > converted to: 0

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Michal Orzel
Hello, On 26/09/2023 07:33, Leo Yan wrote: > > > During the Linux kernel booting, an error is reported by the Xen > hypervisor: > > (XEN) arch/arm/p2m.c:2202: d0v0: Failing to acquire the MFN 0x1a02dc > > The kernel attempts to use an invalid memory frame number, which can be > converted to:

[PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-25 Thread Leo Yan
During the Linux kernel booting, an error is reported by the Xen hypervisor: (XEN) arch/arm/p2m.c:2202: d0v0: Failing to acquire the MFN 0x1a02dc The kernel attempts to use an invalid memory frame number, which can be converted to: 0x1a02dc << PAGE_SHIFT, resulting in 0x1_a02d_c000. The invali