Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-23 Thread Julien Grall
Hi Elliott, On 22/10/2020 20:18, Elliott Mitchell wrote: On Thu, Oct 22, 2020 at 07:38:26PM +0100, Julien Grall wrote: On Thu, Oct 22, 2020 at 07:44:26PM +0100, Julien Grall wrote: Thank you for the patch. FIY I tweak a bit the commit title before committing. The title is now: "xen/arm: acpi:

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-23 Thread Jan Beulich
On 22.10.2020 21:18, Elliott Mitchell wrote: > On Thu, Oct 22, 2020 at 07:44:26PM +0100, Julien Grall wrote: >> Thank you for the patch. FIY I tweak a bit the commit title before >> committing. >> >> The title is now: "xen/arm: acpi: Don't fail it SPCR table is absent". > > Perhaps "xen/arm: acpi

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-22 Thread Jan Beulich
On 22.10.2020 19:13, Elliott Mitchell wrote: > On Thu, Oct 22, 2020 at 09:42:17AM +0200, Jan Beulich wrote: >> On 22.10.2020 00:12, Elliott Mitchell wrote: >>> --- a/xen/arch/arm/acpi/domain_build.c >>> +++ b/xen/arch/arm/acpi/domain_build.c >>> @@ -42,17 +42,18 @@ static int __init acpi_iomem_deny

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-22 Thread Elliott Mitchell
On Thu, Oct 22, 2020 at 07:38:26PM +0100, Julien Grall wrote: > I don't think we are very consistent here... I would not add them > myself, but I don't particularly mind them (I know some editors will add > them automatically). > > I will keep them while committing. For the patch: I would tend

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-22 Thread Julien Grall
Hi, Thank you for the patch. FIY I tweak a bit the commit title before committing. The title is now: "xen/arm: acpi: Don't fail it SPCR table is absent". Cheers, On 21/10/2020 23:12, Elliott Mitchell wrote: Absence of a SPCR table likely means the console is a framebuffer. In such case acp

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-22 Thread Julien Grall
Hi Elliott, On 22/10/2020 18:13, Elliott Mitchell wrote: On Thu, Oct 22, 2020 at 09:42:17AM +0200, Jan Beulich wrote: On 22.10.2020 00:12, Elliott Mitchell wrote: --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -42,17 +42,18 @@ static int __init acpi_iomem_deny

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-22 Thread Elliott Mitchell
On Thu, Oct 22, 2020 at 09:42:17AM +0200, Jan Beulich wrote: > On 22.10.2020 00:12, Elliott Mitchell wrote: > > --- a/xen/arch/arm/acpi/domain_build.c > > +++ b/xen/arch/arm/acpi/domain_build.c > > @@ -42,17 +42,18 @@ static int __init acpi_iomem_deny_access(struct domain > > *d) > > status =

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-22 Thread Jan Beulich
On 22.10.2020 00:12, Elliott Mitchell wrote: > --- a/xen/arch/arm/acpi/domain_build.c > +++ b/xen/arch/arm/acpi/domain_build.c > @@ -42,17 +42,18 @@ static int __init acpi_iomem_deny_access(struct domain *d) > status = acpi_get_table(ACPI_SIG_SPCR, 0, > (struct acp

Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-21 Thread Stefano Stabellini
On Wed, 21 Oct 2020, Elliott Mitchell wrote: > Absence of a SPCR table likely means the console is a framebuffer. In > such case acpi_iomem_deny_access() should NOT fail. > > Signed-off-by: Elliott Mitchell Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/acpi/domain_build.c | 19 ++

[PATCH] xen/acpi: Don't fail if SPCR table is absent

2020-10-21 Thread Elliott Mitchell
Absence of a SPCR table likely means the console is a framebuffer. In such case acpi_iomem_deny_access() should NOT fail. Signed-off-by: Elliott Mitchell --- xen/arch/arm/acpi/domain_build.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/ac