subject:"\[PATCH\] x86emul\: replace UB shifts"

Re: [PATCH] x86emul: replace UB shifts

2020-07-31 Thread Andrew Cooper

On 31/07/2020 08:06, Jan Beulich wrote: > Displacement values can be negative, hence we shouldn't left-shift them. > > While auditing shifts, I noticed a pair of missing parentheses, which > also get added right here. > > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich I'd suggest puttin

[PATCH] x86emul: replace UB shifts

2020-07-31 Thread Jan Beulich

Displacement values can be negative, hence we shouldn't left-shift them. While auditing shifts, I noticed a pair of missing parentheses, which also get added right here. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_em