Re: [PATCH] x86: Prefer d->max_vcpus to dom0_max_vcpus()

2025-07-17 Thread Alejandro Vallejo
On Thu Jul 17, 2025 at 8:49 AM CEST, Jan Beulich wrote: > On 16.07.2025 16:18, Alejandro Vallejo wrote: >> These days d->max_vcpus is populated on domain_create(), so use that instead >> and >> avoid a function call. > > One further nit though: Please limit commit message line length to 75 chars,

Re: [PATCH] x86: Prefer d->max_vcpus to dom0_max_vcpus()

2025-07-16 Thread Jan Beulich
On 16.07.2025 16:18, Alejandro Vallejo wrote: > These days d->max_vcpus is populated on domain_create(), so use that instead > and > avoid a function call. One further nit though: Please limit commit message line length to 75 chars, such that certain git output (indenting by 4 chars) still stays

Re: [PATCH] x86: Prefer d->max_vcpus to dom0_max_vcpus()

2025-07-16 Thread Jason Andryuk
On 2025-07-16 10:18, Alejandro Vallejo wrote: These days d->max_vcpus is populated on domain_create(), so use that instead and avoid a function call. Signed-off-by: Alejandro Vallejo Reviewed-by: Jason Andryuk

Re: [PATCH] x86: Prefer d->max_vcpus to dom0_max_vcpus()

2025-07-16 Thread Jan Beulich
On 16.07.2025 16:18, Alejandro Vallejo wrote: > These days d->max_vcpus is populated on domain_create(), so use that instead > and > avoid a function call. And it's not just this. As it's not straightforward to prove that two runs of this function, at different points in time, would yield the sam

[PATCH] x86: Prefer d->max_vcpus to dom0_max_vcpus()

2025-07-16 Thread Alejandro Vallejo
These days d->max_vcpus is populated on domain_create(), so use that instead and avoid a function call. Signed-off-by: Alejandro Vallejo --- pipeline: https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1930259234 --- xen/arch/x86/hvm/dom0_build.c | 7 +++ xen/arch/x86/io_apic.c