Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-05-03 Thread Andrew Cooper
On 03/05/2021 13:42, Jan Beulich wrote: > On 30.04.2021 00:12, Andrew Cooper wrote: >> The sole user of read_pkru() is the emulated pagewalk, and guarded behind >> guest_pku_enabled() which restricts the path to HVM (hap, even) context only. >> >> The commentary in read_pkru() concerning _PAGE_GNTT

Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-05-03 Thread Jan Beulich
On 30.04.2021 00:12, Andrew Cooper wrote: > The sole user of read_pkru() is the emulated pagewalk, and guarded behind > guest_pku_enabled() which restricts the path to HVM (hap, even) context only. > > The commentary in read_pkru() concerning _PAGE_GNTTAB overlapping with > _PAGE_PKEY_BITS is only

Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-04-30 Thread Jan Beulich
On 30.04.2021 16:37, Andrew Cooper wrote: > On 30/04/2021 11:42, Jan Beulich wrote: >> On 30.04.2021 12:21, Andrew Cooper wrote: >>> If I do the rebase, are you happy for this patch to stay as it is (so >>> the complicated change concerning context switching doesn't get more >>> complicated), and s

Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-04-30 Thread Andrew Cooper
On 30/04/2021 11:42, Jan Beulich wrote: > On 30.04.2021 12:21, Andrew Cooper wrote: >> On 30/04/2021 10:08, Jan Beulich wrote: >>> On 30.04.2021 00:12, Andrew Cooper wrote: The sole user of read_pkru() is the emulated pagewalk, and guarded behind guest_pku_enabled() which restricts the pa

Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-04-30 Thread Jan Beulich
On 30.04.2021 12:21, Andrew Cooper wrote: > On 30/04/2021 10:08, Jan Beulich wrote: >> On 30.04.2021 00:12, Andrew Cooper wrote: >>> The sole user of read_pkru() is the emulated pagewalk, and guarded behind >>> guest_pku_enabled() which restricts the path to HVM (hap, even) context >>> only. >>> >

Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-04-30 Thread Andrew Cooper
On 30/04/2021 10:08, Jan Beulich wrote: > On 30.04.2021 00:12, Andrew Cooper wrote: >> The sole user of read_pkru() is the emulated pagewalk, and guarded behind >> guest_pku_enabled() which restricts the path to HVM (hap, even) context only. >> >> The commentary in read_pkru() concerning _PAGE_GNTT

Re: [PATCH] x86: Always have CR4.PKE set in HVM context

2021-04-30 Thread Jan Beulich
On 30.04.2021 00:12, Andrew Cooper wrote: > The sole user of read_pkru() is the emulated pagewalk, and guarded behind > guest_pku_enabled() which restricts the path to HVM (hap, even) context only. > > The commentary in read_pkru() concerning _PAGE_GNTTAB overlapping with > _PAGE_PKEY_BITS is only

[PATCH] x86: Always have CR4.PKE set in HVM context

2021-04-29 Thread Andrew Cooper
The sole user of read_pkru() is the emulated pagewalk, and guarded behind guest_pku_enabled() which restricts the path to HVM (hap, even) context only. The commentary in read_pkru() concerning _PAGE_GNTTAB overlapping with _PAGE_PKEY_BITS is only applicable to PV guests. The context switch path,