Re: [PATCH] x86/vpmu: Simplify is_pmc_quirk

2023-06-21 Thread Andrew Cooper
On 21/06/2023 9:16 am, Jan Beulich wrote: > On 20.06.2023 19:45, Andrew Cooper wrote: >> This should be static, and there's no need for a separate (non-init, even) >> function to perform a simple equality test. Drop the is_ prefix which is >> gramatically questionable, and make it __ro_after_init.

Re: [PATCH] x86/vpmu: Simplify is_pmc_quirk

2023-06-21 Thread Jan Beulich
On 20.06.2023 19:45, Andrew Cooper wrote: > This should be static, and there's no need for a separate (non-init, even) > function to perform a simple equality test. Drop the is_ prefix which is > gramatically questionable, and make it __ro_after_init. > > Leave a TODO, because the behaviour is de

[PATCH] x86/vpmu: Simplify is_pmc_quirk

2023-06-20 Thread Andrew Cooper
This should be static, and there's no need for a separate (non-init, even) function to perform a simple equality test. Drop the is_ prefix which is gramatically questionable, and make it __ro_after_init. Leave a TODO, because the behaviour is definitely wrong to be applied to ~all modern Intel CP