Re: [PATCH] x86/vPIC: check values loaded from state save record

2023-10-25 Thread Roger Pau Monné
On Wed, Oct 25, 2023 at 01:51:05PM +0200, Jan Beulich wrote: > On 25.10.2023 12:12, Roger Pau Monné wrote: > > On Thu, May 11, 2023 at 01:50:33PM +0200, Jan Beulich wrote: > >> Loading is_master from the state save record can lead to out-of-bounds > >> accesses via at least the two container_of() u

Re: [PATCH] x86/vPIC: check values loaded from state save record

2023-10-25 Thread Jan Beulich
On 25.10.2023 12:12, Roger Pau Monné wrote: > On Thu, May 11, 2023 at 01:50:33PM +0200, Jan Beulich wrote: >> Loading is_master from the state save record can lead to out-of-bounds >> accesses via at least the two container_of() uses by vpic_domain() and >> __vpic_lock(). Calculate the field from t

Re: [PATCH] x86/vPIC: check values loaded from state save record

2023-10-25 Thread Roger Pau Monné
On Thu, May 11, 2023 at 01:50:33PM +0200, Jan Beulich wrote: > Loading is_master from the state save record can lead to out-of-bounds > accesses via at least the two container_of() uses by vpic_domain() and > __vpic_lock(). Calculate the field from the supplied instance number > instead. Adjust the

[PATCH] x86/vPIC: check values loaded from state save record

2023-05-11 Thread Jan Beulich
Loading is_master from the state save record can lead to out-of-bounds accesses via at least the two container_of() uses by vpic_domain() and __vpic_lock(). Calculate the field from the supplied instance number instead. Adjust the public header comment accordingly. For ELCR follow what vpic_interc