Re: [PATCH] x86/traps: Make nmi_show_execution_state() more useful

2022-08-15 Thread Jan Beulich
On 12.08.2022 19:33, Andrew Cooper wrote: > * Always emit current. It's critically important. I agree it may be relevant, yet I'm not convinced of "critically". But anyway. > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -768,8 +768,14 @@ static int cf_check nmi_show_execution_st

[PATCH] x86/traps: Make nmi_show_execution_state() more useful

2022-08-12 Thread Andrew Cooper
* Always emit current. It's critically important. * Do not render () for the symbol in guest context. It's just line-noise. Instead, explicitly identify which Xen vs guest context. * Try to tabulate the data, because there is often lots of it. Signed-off-by: Andrew Cooper