Re: [PATCH] x86/shadow: fix DO_UNSHADOW()

2021-05-24 Thread Tim Deegan
At 14:36 +0200 on 19 May (1621434982), Jan Beulich wrote: > When adding the HASH_CALLBACKS_CHECK() I failed to properly recognize > the (somewhat unusually formatted) if() around the call to > hash_domain_foreach()). Gcc 11 is absolutely right in pointing out the > apparently misleading indentation

Re: [PATCH] x86/shadow: fix DO_UNSHADOW()

2021-05-19 Thread Luca Fancellu
> On 19 May 2021, at 13:36, Jan Beulich wrote: > > When adding the HASH_CALLBACKS_CHECK() I failed to properly recognize > the (somewhat unusually formatted) if() around the call to > hash_domain_foreach()). Gcc 11 is absolutely right in pointing out the > apparently misleading indentation. Be

[PATCH] x86/shadow: fix DO_UNSHADOW()

2021-05-19 Thread Jan Beulich
When adding the HASH_CALLBACKS_CHECK() I failed to properly recognize the (somewhat unusually formatted) if() around the call to hash_domain_foreach()). Gcc 11 is absolutely right in pointing out the apparently misleading indentation. Besides adding the missing braces, also adjust the two oddly for