Re: [PATCH] x86/shadow: Drop dubious lastpage diagnostic

2023-01-20 Thread Andrew Cooper
On 20/01/2023 2:39 pm, Andrew Cooper wrote: > On 20/01/2023 2:20 pm, Jan Beulich wrote: >> On 20.01.2023 15:10, Andrew Cooper wrote: >>> On 20/01/2023 1:10 pm, Jan Beulich wrote: On 20.01.2023 12:45, Andrew Cooper wrote: > This is a global variable (actually 3, one per GUEST_PAGING_LEVEL),

Re: [PATCH] x86/shadow: Drop dubious lastpage diagnostic

2023-01-20 Thread Andrew Cooper
On 20/01/2023 2:20 pm, Jan Beulich wrote: > On 20.01.2023 15:10, Andrew Cooper wrote: >> On 20/01/2023 1:10 pm, Jan Beulich wrote: >>> On 20.01.2023 12:45, Andrew Cooper wrote: This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated on using atomics only (with n

Re: [PATCH] x86/shadow: Drop dubious lastpage diagnostic

2023-01-20 Thread Jan Beulich
On 20.01.2023 15:10, Andrew Cooper wrote: > On 20/01/2023 1:10 pm, Jan Beulich wrote: >> On 20.01.2023 12:45, Andrew Cooper wrote: >>> This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated >>> on using atomics only (with no regard to what else shares the same >>> cacheline),

Re: [PATCH] x86/shadow: Drop dubious lastpage diagnostic

2023-01-20 Thread Andrew Cooper
On 20/01/2023 1:10 pm, Jan Beulich wrote: > On 20.01.2023 12:45, Andrew Cooper wrote: >> This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated >> on using atomics only (with no regard to what else shares the same >> cacheline), >> which emits a diagnostic (in debug builds on

Re: [PATCH] x86/shadow: Drop dubious lastpage diagnostic

2023-01-20 Thread Jan Beulich
On 20.01.2023 12:45, Andrew Cooper wrote: > This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated > on using atomics only (with no regard to what else shares the same cacheline), > which emits a diagnostic (in debug builds only) without changing any program > behaviour. > >

[PATCH] x86/shadow: Drop dubious lastpage diagnostic

2023-01-20 Thread Andrew Cooper
This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated on using atomics only (with no regard to what else shares the same cacheline), which emits a diagnostic (in debug builds only) without changing any program behaviour. Based on read-only p2m types including logdirty, this