Re: [PATCH] x86/p2m: Fix paging_gva_to_gfn() for nested virt

2021-01-04 Thread Roger Pau Monné
On Thu, Dec 31, 2020 at 05:10:21PM +, Andrew Cooper wrote: > nestedhap_walk_L1_p2m() takes guest physical addresses, not frame numbers. > This means the l2 input is off-by-PAGE_SHIFT, as is the l1 value eventually > returned to the caller. > > Delete the misleading comment as well. > > Fixes:

Re: [PATCH] x86/p2m: Fix paging_gva_to_gfn() for nested virt

2020-12-31 Thread Tamas K Lengyel
On Thu, Dec 31, 2020 at 12:11 PM Andrew Cooper wrote: > > nestedhap_walk_L1_p2m() takes guest physical addresses, not frame numbers. > This means the l2 input is off-by-PAGE_SHIFT, as is the l1 value eventually > returned to the caller. > > Delete the misleading comment as well. > > Fixes: bab2bd8

[PATCH] x86/p2m: Fix paging_gva_to_gfn() for nested virt

2020-12-31 Thread Andrew Cooper
nestedhap_walk_L1_p2m() takes guest physical addresses, not frame numbers. This means the l2 input is off-by-PAGE_SHIFT, as is the l1 value eventually returned to the caller. Delete the misleading comment as well. Fixes: bab2bd8e222de ("xen/nested_p2m: Don't walk EPT tables with a regular PT wal