Re: [PATCH] x86/msi: prevent MSI entry re-writes of the same data

2025-03-06 Thread Jan Beulich
On 05.03.2025 18:57, Roger Pau Monné wrote: > On Wed, Mar 05, 2025 at 11:30:51AM +0100, Jan Beulich wrote: >> On 28.02.2025 12:32, Roger Pau Monne wrote: >>> @@ -1407,7 +1415,9 @@ int pci_restore_msi_state(struct pci_dev *pdev) >>> } >>> type = entry->msi_attrib.type; >>> >>> -

Re: [PATCH] x86/msi: prevent MSI entry re-writes of the same data

2025-03-05 Thread Roger Pau Monné
On Wed, Mar 05, 2025 at 11:30:51AM +0100, Jan Beulich wrote: > On 28.02.2025 12:32, Roger Pau Monne wrote: > > @@ -191,8 +193,6 @@ void msi_compose_msg(unsigned vector, const cpumask_t > > *cpu_mask, struct msi_msg > > > > static int write_msi_msg(struct msi_desc *entry, struct msi_msg *msg) >

Re: [PATCH] x86/msi: prevent MSI entry re-writes of the same data

2025-03-05 Thread Jan Beulich
On 28.02.2025 12:32, Roger Pau Monne wrote: > @@ -191,8 +193,6 @@ void msi_compose_msg(unsigned vector, const cpumask_t > *cpu_mask, struct msi_msg > > static int write_msi_msg(struct msi_desc *entry, struct msi_msg *msg) > { > -entry->msg = *msg; > - > if ( iommu_intremap != iommu_in

[PATCH] x86/msi: prevent MSI entry re-writes of the same data

2025-02-28 Thread Roger Pau Monne
Attempt to reduce the MSI entry writes, and the associated checking whether memory decoding and MSI-X is enabled for the PCI device, when the MSI data hasn't changed. When using Interrupt Remapping the MSI entry will contain an index into the remapping table, and it's in such remapping table where