Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-05-26 Thread Andrew Cooper
On 26/05/2022 16:31, Jan Beulich wrote: > On 27.04.2022 16:04, Andrew Cooper wrote: >> mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for >> speculative defence. Avoid calling it redundantly, and just store the result >> of the first call. > Since it took quite some time

Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-05-26 Thread Jan Beulich
On 27.04.2022 16:04, Andrew Cooper wrote: > mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for > speculative defence. Avoid calling it redundantly, and just store the result > of the first call. Since it took quite some time for this to actually be committed, I did notic

Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-04-27 Thread Jan Beulich
On 27.04.2022 16:04, Andrew Cooper wrote: > mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for > speculative defence. Avoid calling it redundantly, and just store the result > of the first call. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

[PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-04-27 Thread Andrew Cooper
mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for speculative defence. Avoid calling it redundantly, and just store the result of the first call. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/mm.c | 8 +--- 1