Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only

2022-11-30 Thread Daniel P. Smith
On 11/30/22 02:52, Jan Beulich wrote: On 29.11.2022 21:56, Andrew Cooper wrote: On 29/11/2022 14:55, Jan Beulich wrote: By defining the constant to zero when !SHADOW_PAGING we give compilers the chance to eliminate a little more dead code elsewhere in the tree. Plus, as a minor benefit, the gen

Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only

2022-11-30 Thread Andrew Cooper
On 30/11/2022 07:52, Jan Beulich wrote:On 29.11.2022 21:56, Andrew Cooper wrote: >> On 29/11/2022 14:55, Jan Beulich wrote: >>> By defining the constant to zero when !SHADOW_PAGING we give compilers >>> the chance to eliminate a little more dead code elsewhere in the tree. >>> Plus, as a minor bene

Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only

2022-11-29 Thread Jan Beulich
On 29.11.2022 21:56, Andrew Cooper wrote: > On 29/11/2022 14:55, Jan Beulich wrote: >> By defining the constant to zero when !SHADOW_PAGING we give compilers >> the chance to eliminate a little more dead code elsewhere in the tree. >> Plus, as a minor benefit, the general reference count can be one

Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only

2022-11-29 Thread Andrew Cooper
On 29/11/2022 20:56, Andrew Cooper wrote: > On 29/11/2022 14:55, Jan Beulich wrote: >> By defining the constant to zero when !SHADOW_PAGING we give compilers >> the chance to eliminate a little more dead code elsewhere in the tree. >> Plus, as a minor benefit, the general reference count can be one

Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only

2022-11-29 Thread Andrew Cooper
On 29/11/2022 14:55, Jan Beulich wrote: > By defining the constant to zero when !SHADOW_PAGING we give compilers > the chance to eliminate a little more dead code elsewhere in the tree. > Plus, as a minor benefit, the general reference count can be one bit > wider. (To simplify things, have PGC_pag

[PATCH] x86/mm: PGC_page_table is used by shadow code only

2022-11-29 Thread Jan Beulich
By defining the constant to zero when !SHADOW_PAGING we give compilers the chance to eliminate a little more dead code elsewhere in the tree. Plus, as a minor benefit, the general reference count can be one bit wider. (To simplify things, have PGC_page_table change places with PGC_extra.) Signed-o