Re: [PATCH] x86/ioapic: Improve code generation for __io_apic_{read,write}()

2020-08-05 Thread Jan Beulich
On 05.08.2020 15:54, Andrew Cooper wrote: > The write into REGSEL prevents the optimiser from reusing the address > calculation, forcing it to be calcualted twice. > > The calculation itself is quite expensive. Pull it out into a local varaible. > > Bloat-o-meter reports: > add/remove: 0/0 gro

[PATCH] x86/ioapic: Improve code generation for __io_apic_{read, write}()

2020-08-05 Thread Andrew Cooper
The write into REGSEL prevents the optimiser from reusing the address calculation, forcing it to be calcualted twice. The calculation itself is quite expensive. Pull it out into a local varaible. Bloat-o-meter reports: add/remove: 0/0 grow/shrink: 0/26 up/down: 0/-1527 (-1527) Also correct th