Re: [PATCH] x86/ioapic: Fix fixmap error path logic in ioapic_init_mappings()

On 05.08.2020 14:51, Andrew Cooper wrote: > In the case that bad_ioapic_register() fails, the current position of idx++ > means that clear_fixmap(idx) will be called with the wrong index, and not > clean up the mapping just created. > > Increment idx as part of the loop, rather than midway through

[PATCH] x86/ioapic: Fix fixmap error path logic in ioapic_init_mappings()

In the case that bad_ioapic_register() fails, the current position of idx++ means that clear_fixmap(idx) will be called with the wrong index, and not clean up the mapping just created. Increment idx as part of the loop, rather than midway through the loop body. Signed-off-by: Andrew Cooper --- C