Re: [PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Jan Beulich
On 08.01.2021 16:42, Roger Pau Monne wrote: > A pvshim build doesn't require the grant table functionality built in, > but it does require knowing the number of arguments the hypercall has > so the hypercall parameter clobbering works properly. > > Instead of also setting the argument count for th

[PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Roger Pau Monne
A pvshim build doesn't require the grant table functionality built in, but it does require knowing the number of arguments the hypercall has so the hypercall parameter clobbering works properly. Instead of also setting the argument count for the gnttab case if PV shim functionality is enabled, jus

Re: [PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Roger Pau Monné
On Fri, Jan 08, 2021 at 04:24:01PM +0100, Jan Beulich wrote: > On 08.01.2021 16:11, Roger Pau Monné wrote: > > On Fri, Jan 08, 2021 at 04:01:52PM +0100, Jan Beulich wrote: > >> On 08.01.2021 15:41, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/hypercall.c > >>> +++ b/xen/arch/x86/hypercall.c > >>

Re: [PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Jan Beulich
On 08.01.2021 16:24, Jan Beulich wrote: > On 08.01.2021 16:11, Roger Pau Monné wrote: >> On Fri, Jan 08, 2021 at 04:01:52PM +0100, Jan Beulich wrote: >>> On 08.01.2021 15:41, Roger Pau Monne wrote: --- a/xen/arch/x86/hypercall.c +++ b/xen/arch/x86/hypercall.c @@ -47,7 +47,7 @@ const

Re: [PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Jan Beulich
On 08.01.2021 16:11, Roger Pau Monné wrote: > On Fri, Jan 08, 2021 at 04:01:52PM +0100, Jan Beulich wrote: >> On 08.01.2021 15:41, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hypercall.c >>> +++ b/xen/arch/x86/hypercall.c >>> @@ -47,7 +47,7 @@ const hypercall_args_t >>> hypercall_args_table[NR_h

Re: [PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Roger Pau Monné
On Fri, Jan 08, 2021 at 04:01:52PM +0100, Jan Beulich wrote: > On 08.01.2021 15:41, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hypercall.c > > +++ b/xen/arch/x86/hypercall.c > > @@ -47,7 +47,7 @@ const hypercall_args_t > > hypercall_args_table[NR_hypercalls] = > > ARGS(xen_version, 2), > >

Re: [PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Jan Beulich
On 08.01.2021 15:41, Roger Pau Monne wrote: > --- a/xen/arch/x86/hypercall.c > +++ b/xen/arch/x86/hypercall.c > @@ -47,7 +47,7 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] = > ARGS(xen_version, 2), > ARGS(console_io, 3), > ARGS(physdev_op_compat, 1), > -#ifdef CONFIG

[PATCH] x86/hypercall: fix gnttab hypercall args conditional build on pvshim

2021-01-08 Thread Roger Pau Monne
A pvshim build doesn't require the grant table functionality built in, but it does require knowing the number of arguments the hypercall has so the hypercall parameter clobbering works properly. Note this hasn't been detected by osstest because the tools pvshim build is done without debug enabled,