Re: [PATCH] x86/hvm: Remove callback from paging->flush_tlb() hook

2021-11-18 Thread Durrant, Paul
On 18/11/2021 11:19, Andrew Cooper wrote: On 18/11/2021 10:45, Jan Beulich wrote: On 17.11.2021 19:26, Andrew Cooper wrote: TLB flushing is a hotpath, and function pointer calls are expensive (especially under repoline) for what amounts to an identity transform on the data. Just pass the vcpu_

Re: [PATCH] x86/hvm: Remove callback from paging->flush_tlb() hook

2021-11-18 Thread Andrew Cooper
On 18/11/2021 10:45, Jan Beulich wrote: > On 17.11.2021 19:26, Andrew Cooper wrote: >> TLB flushing is a hotpath, and function pointer calls are >> expensive (especially under repoline) for what amounts to an identity >> transform on the data. Just pass the vcpu_bitmap bitmap directly. >> >> As we

Re: [PATCH] x86/hvm: Remove callback from paging->flush_tlb() hook

2021-11-18 Thread Jan Beulich
On 17.11.2021 19:26, Andrew Cooper wrote: > TLB flushing is a hotpath, and function pointer calls are > expensive (especially under repoline) for what amounts to an identity > transform on the data. Just pass the vcpu_bitmap bitmap directly. > > As we use NULL for all rather than none, introduce

[PATCH] x86/hvm: Remove callback from paging->flush_tlb() hook

2021-11-17 Thread Andrew Cooper
TLB flushing is a hotpath, and function pointer calls are expensive (especially under repoline) for what amounts to an identity transform on the data. Just pass the vcpu_bitmap bitmap directly. As we use NULL for all rather than none, introduce a flush_vcpu() helper to avoid the risk of logical e