Re: [PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-28 Thread Andrew Cooper
On 23/07/2020 11:25, Jan Beulich wrote: > On 23.07.2020 11:40, Andrew Cooper wrote: >> On 22/07/2020 17:13, Jan Beulich wrote: >>> On 22.07.2020 17:15, Andrew Cooper wrote: * Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the lower levels. * Use DIV_ROUND_UP

Re: [PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-26 Thread Tim Deegan
At 16:15 +0100 on 22 Jul (1595434548), Andrew Cooper wrote: > * Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the >lower levels. > * Use DIV_ROUND_UP() rather than opencoding it in several different ways > * The hypercall input is capped at uint32_t, so there is no need

Re: [PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-23 Thread Jan Beulich
On 23.07.2020 11:40, Andrew Cooper wrote: > On 22/07/2020 17:13, Jan Beulich wrote: >> On 22.07.2020 17:15, Andrew Cooper wrote: >>> * Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the >>>lower levels. >>> * Use DIV_ROUND_UP() rather than opencoding it in several differe

Re: [PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-23 Thread Andrew Cooper
On 22/07/2020 17:13, Jan Beulich wrote: > On 22.07.2020 17:15, Andrew Cooper wrote: >> * Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the >>lower levels. >> * Use DIV_ROUND_UP() rather than opencoding it in several different ways >> * The hypercall input is capped at u

Re: [PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-22 Thread Jan Beulich
On 22.07.2020 17:15, Andrew Cooper wrote: > * Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the >lower levels. > * Use DIV_ROUND_UP() rather than opencoding it in several different ways > * The hypercall input is capped at uint32_t, so there is no need for >nr_frame

[PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-22 Thread Andrew Cooper
* Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the lower levels. * Use DIV_ROUND_UP() rather than opencoding it in several different ways * The hypercall input is capped at uint32_t, so there is no need for nr_frames to be unsigned long in the lower levels. No funct