Re: [PATCH] x86/cpuid: Drop special_features[]

2021-06-08 Thread Jan Beulich
On 08.06.2021 10:46, Andrew Cooper wrote: > On 08/06/2021 07:18, Jan Beulich wrote: >> On 07.06.2021 14:41, Andrew Cooper wrote: >>> While the ! annotation is useful to indicate that something special is >>> happening, an array of bits is not. Drop it, to prevent mistakes. >>> >>> Signed-off-by: A

Re: [PATCH] x86/cpuid: Drop special_features[]

2021-06-08 Thread Andrew Cooper
On 08/06/2021 07:18, Jan Beulich wrote: > On 07.06.2021 14:41, Andrew Cooper wrote: >> While the ! annotation is useful to indicate that something special is >> happening, an array of bits is not. Drop it, to prevent mistakes. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: R

Re: [PATCH] x86/cpuid: Drop special_features[]

2021-06-07 Thread Jan Beulich
On 07.06.2021 14:41, Andrew Cooper wrote: > While the ! annotation is useful to indicate that something special is > happening, an array of bits is not. Drop it, to prevent mistakes. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > xen/arch

Re: [PATCH] x86/cpuid: Drop special_features[]

2021-06-07 Thread Jan Beulich
On 07.06.2021 14:41, Andrew Cooper wrote: > While the ! annotation is useful to indicate that something special is > happening, an array of bits is not. Drop it, to prevent mistakes. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

[PATCH] x86/cpuid: Drop special_features[]

2021-06-07 Thread Andrew Cooper
While the ! annotation is useful to indicate that something special is happening, an array of bits is not. Drop it, to prevent mistakes. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/cpuid.c| 2 -- xen/include/asm-x86/cpuid.h | 1 -