Re: [PATCH] x86/cpu-policy: Fix handling of leaf 0x80000021

2025-07-02 Thread Andrew Cooper
On 01/07/2025 11:53 am, Andrew Cooper wrote: > diff --git a/xen/include/xen/lib/x86/cpu-policy.h > b/xen/include/xen/lib/x86/cpu-policy.h > index f43e1a3b21e9..aeaa16bbc732 100644 > --- a/xen/include/xen/lib/x86/cpu-policy.h > +++ b/xen/include/xen/lib/x86/cpu-policy.h > @@ -325,7 +325,10 @@ struc

Re: [PATCH] x86/cpu-policy: Fix handling of leaf 0x80000021

2025-07-01 Thread Andrew Cooper
On 01/07/2025 1:11 pm, Jan Beulich wrote: > On 01.07.2025 12:53, Andrew Cooper wrote: >> When support was originally introduced, ebx, ecx and edx were reserved and >> should have been zeroed in recalculate_misc() to avoid leaking into guests. >> >> Since then, fields have been added into ebx. Gues

Re: [PATCH] x86/cpu-policy: Fix handling of leaf 0x80000021

2025-07-01 Thread Jan Beulich
On 01.07.2025 12:53, Andrew Cooper wrote: > When support was originally introduced, ebx, ecx and edx were reserved and > should have been zeroed in recalculate_misc() to avoid leaking into guests. > > Since then, fields have been added into ebx. Guests can't load microcode, so > shouldn't see uco

[PATCH] x86/cpu-policy: Fix handling of leaf 0x80000021

2025-07-01 Thread Andrew Cooper
When support was originally introduced, ebx, ecx and edx were reserved and should have been zeroed in recalculate_misc() to avoid leaking into guests. Since then, fields have been added into ebx. Guests can't load microcode, so shouldn't see ucode_size, and while in principle we do want to suppor