Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Jason Andryuk
On Wed, May 13, 2020 at 9:56 AM Andrew Cooper wrote: > > Xen doesn't support CET-IBT yet. At a minimum, logic is required to enable it > for supervisor use, but the livepatch functionality needs to learn not to > overwrite ENDBR64 instructions. > > Furthermore, Ubuntu enables -fcf-protection by d

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Andrew Cooper
On 13/05/2020 15:13, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 13.05.2020 15:55, Andrew Cooper wrote: >> Xen doesn't support CET-IBT yet. At a minimum, logic is required

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Jan Beulich
On 13.05.2020 15:55, Andrew Cooper wrote: > Xen doesn't support CET-IBT yet. At a minimum, logic is required to enable it > for supervisor use, but the livepatch functionality needs to learn not to > overwrite ENDBR64 instructions. > > Furthermore, Ubuntu enables -fcf-protection by default, along

[PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Andrew Cooper
Xen doesn't support CET-IBT yet. At a minimum, logic is required to enable it for supervisor use, but the livepatch functionality needs to learn not to overwrite ENDBR64 instructions. Furthermore, Ubuntu enables -fcf-protection by default, along with a buggy version of GCC-9 which objects to it i

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Jason Andryuk
On Wed, May 13, 2020 at 7:01 AM Andrew Cooper wrote: > > On 13/05/2020 03:35, Jason Andryuk wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > > unless you have verified the sender and know the content is safe. > > > > On Tue, May 12, 2020 at 3:11 PM Andrew Coo

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Andrew Cooper
On 13/05/2020 03:35, Jason Andryuk wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Tue, May 12, 2020 at 3:11 PM Andrew Cooper > wrote: >> See comment for details. Works around a GCC-9 b

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-13 Thread Jan Beulich
On 12.05.2020 21:11, Andrew Cooper wrote: > See comment for details. Works around a GCC-9 bug which breaks the build on > Ubuntu. > > Reported-by: Jason Andryuk > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-12 Thread Jason Andryuk
On Tue, May 12, 2020 at 3:11 PM Andrew Cooper wrote: > > See comment for details. Works around a GCC-9 bug which breaks the build on > Ubuntu. > > Reported-by: Jason Andryuk > Signed-off-by: Andrew Cooper Tested-by: Jason Andryuk Reviewed-by: Jason Andryuk > diff --git a/xen/arch/x86/arch.m

[PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-12 Thread Andrew Cooper
See comment for details. Works around a GCC-9 bug which breaks the build on Ubuntu. Reported-by: Jason Andryuk Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Jason Andryuk CC: Stefan Bader Sorry for messing you around with how to fix this. I'd neglec