Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Boris Ostrovsky
On 5/21/21 9:15 AM, Jan Beulich wrote: > On 21.05.2021 15:12, Boris Ostrovsky wrote: >> >> Did something changed recently that this became a problem? That commit has >> been there for 3 years. > He happened to try on a system where NX was turned off in the BIOS. Yes, I missed that part. -bor

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Jan Beulich
On 21.05.2021 15:12, Boris Ostrovsky wrote: > > On 5/21/21 3:45 AM, Juergen Gross wrote: >> On 21.05.21 09:26, Jan Beulich wrote: >>> On 21.05.2021 09:18, Juergen Gross wrote: On 20.05.21 14:08, Jan Beulich wrote: > On 20.05.2021 13:57, Juergen Gross wrote: >> On 20.05.21 13:42, Jan B

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Boris Ostrovsky
On 5/21/21 3:45 AM, Juergen Gross wrote: > On 21.05.21 09:26, Jan Beulich wrote: >> On 21.05.2021 09:18, Juergen Gross wrote: >>> On 20.05.21 14:08, Jan Beulich wrote: On 20.05.2021 13:57, Juergen Gross wrote: > On 20.05.21 13:42, Jan Beulich wrote: >> xen_setup_gdt(), via xen_load_g

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Juergen Gross
On 20.05.21 13:42, Jan Beulich wrote: xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX is not available, x86_configure_nx() needs to be called first. Reported-by: Olaf Hering Signed-off-by: Jan Beulich Pushed to xen/tip.git for-linus-5.13b Jue

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Juergen Gross
On 21.05.21 09:26, Jan Beulich wrote: On 21.05.2021 09:18, Juergen Gross wrote: On 20.05.21 14:08, Jan Beulich wrote: On 20.05.2021 13:57, Juergen Gross wrote: On 20.05.21 13:42, Jan Beulich wrote: xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Jan Beulich
On 21.05.2021 09:18, Juergen Gross wrote: > On 20.05.21 14:08, Jan Beulich wrote: >> On 20.05.2021 13:57, Juergen Gross wrote: >>> On 20.05.21 13:42, Jan Beulich wrote: xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX is not available, x86_co

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-21 Thread Juergen Gross
On 20.05.21 14:08, Jan Beulich wrote: On 20.05.2021 13:57, Juergen Gross wrote: On 20.05.21 13:42, Jan Beulich wrote: xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX is not available, x86_configure_nx() needs to be called first. Reported-by: Olaf

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-20 Thread Juergen Gross
On 20.05.21 14:08, Jan Beulich wrote: On 20.05.2021 13:57, Juergen Gross wrote: On 20.05.21 13:42, Jan Beulich wrote: xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX is not available, x86_configure_nx() needs to be called first. Reported-by: Olaf

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-20 Thread Jan Beulich
On 20.05.2021 13:57, Juergen Gross wrote: > On 20.05.21 13:42, Jan Beulich wrote: >> xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. >> For this to work when NX is not available, x86_configure_nx() needs to >> be called first. >> >> Reported-by: Olaf Hering >> Signed-off-by:

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-20 Thread Juergen Gross
On 20.05.21 13:42, Jan Beulich wrote: xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX is not available, x86_configure_nx() needs to be called first. Reported-by: Olaf Hering Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen Ope

[PATCH] x86/Xen: swap NX determination and GDT setup on BSP

2021-05-20 Thread Jan Beulich
xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. For this to work when NX is not available, x86_configure_nx() needs to be called first. Reported-by: Olaf Hering Signed-off-by: Jan Beulich --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1273,16 +127