Re: [PATCH] x86/S3: don't lose previously collected CPU data (AMD extra)

2025-07-17 Thread Juergen Gross
On 17.07.25 17:18, Jan Beulich wrote: smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume, hence it is wrong to zap APs' data while bringing them down (and we're not just parking them there) during suspend. Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]") Sig

[PATCH] x86/S3: don't lose previously collected CPU data (AMD extra)

2025-07-17 Thread Jan Beulich
smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume, hence it is wrong to zap APs' data while bringing them down (and we're not just parking them there) during suspend. Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]") Signed-off-by: Jan Beulich --- a/xen/arch

Re: [PATCH] x86/S3: don't lose previously collected CPU data

2025-07-17 Thread Roger Pau Monné
On Thu, Jul 17, 2025 at 12:14:54PM +0200, Jan Beulich wrote: > smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume, > hence it is wrong to overwrite APs' data using boot_cpu_data. With > 7126b7f806d54 ("x86/CPU: re-work populating of cpu_data[]") this now > results in a crash, a

[PATCH] x86/S3: don't lose previously collected CPU data

2025-07-17 Thread Jan Beulich
smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume, hence it is wrong to overwrite APs' data using boot_cpu_data. With 7126b7f806d54 ("x86/CPU: re-work populating of cpu_data[]") this now results in a crash, as the cpu_to_socket() use in smp_store_cpu_info() then obtains a bad