Re: [PATCH] x86/S3: Restore CR4 earlier during resume

2020-10-05 Thread Marek Marczykowski-Górecki
On Fri, Oct 02, 2020 at 10:36:50PM +0100, Andrew Cooper wrote: > c/s 4304ff420e5 "x86/S3: Drop {save,restore}_rest_processor_state() > completely" moved CR4 restoration up into C, to account for the fact that MCE > was explicitly handled later. > > However, time_resume() ends up making an EFI Runt

Re: [PATCH] x86/S3: Restore CR4 earlier during resume

2020-10-04 Thread Andrew Cooper
On 04/10/2020 08:38, Jan Beulich wrote: > On 02.10.2020 23:36, Andrew Cooper wrote: >> c/s 4304ff420e5 "x86/S3: Drop {save,restore}_rest_processor_state() >> completely" moved CR4 restoration up into C, to account for the fact that MCE >> was explicitly handled later. >> >> However, time_resume() e

Re: [PATCH] x86/S3: Restore CR4 earlier during resume

2020-10-04 Thread Jan Beulich
On 02.10.2020 23:36, Andrew Cooper wrote: > c/s 4304ff420e5 "x86/S3: Drop {save,restore}_rest_processor_state() > completely" moved CR4 restoration up into C, to account for the fact that MCE > was explicitly handled later. > > However, time_resume() ends up making an EFI Runtime Service call, and

[PATCH] x86/S3: Restore CR4 earlier during resume

2020-10-02 Thread Andrew Cooper
c/s 4304ff420e5 "x86/S3: Drop {save,restore}_rest_processor_state() completely" moved CR4 restoration up into C, to account for the fact that MCE was explicitly handled later. However, time_resume() ends up making an EFI Runtime Service call, and EFI explodes without OSFXSR, presumably when trying