Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-11 Thread Roger Pau Monné
On Mon, May 11, 2020 at 03:46:38PM +0200, Jan Beulich wrote: > On 08.05.2020 18:08, Roger Pau Monné wrote: > > On Fri, May 08, 2020 at 05:11:35PM +0200, Jan Beulich wrote: > >> On 08.05.2020 17:03, Roger Pau Monné wrote: > >>> On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: > ---

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-11 Thread Jan Beulich
On 08.05.2020 18:08, Roger Pau Monné wrote: > On Fri, May 08, 2020 at 05:11:35PM +0200, Jan Beulich wrote: >> On 08.05.2020 17:03, Roger Pau Monné wrote: >>> On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -558,6

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 05:11:35PM +0200, Jan Beulich wrote: > On 08.05.2020 17:03, Roger Pau Monné wrote: > > On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: > >> --- a/xen/arch/x86/hvm/io.c > >> +++ b/xen/arch/x86/hvm/io.c > >> @@ -558,6 +558,47 @@ int register_vpci_mmcfg_handler(str

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Jan Beulich
On 08.05.2020 17:03, Roger Pau Monné wrote: > On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/io.c >> +++ b/xen/arch/x86/hvm/io.c >> @@ -558,6 +558,47 @@ int register_vpci_mmcfg_handler(struct d >> return 0; >> } >> >> +int unregister_vpci_mmcfg_handle

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: > The op has a register/unregister flag, and hence registration shouldn't > happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle > this case. > > Fixes: eb3dd90e4089 ("x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 03:49:35PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 08.05.2020 14:54, Andrew Cooper wrote: > > On 08/05/2020 13:43, Jan Beulich wrote: >

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Jan Beulich
On 08.05.2020 14:54, Andrew Cooper wrote: > On 08/05/2020 13:43, Jan Beulich wrote: >> The op has a register/unregister flag, and hence registration shouldn't >> happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle >> this case. >> >> Fixes: eb3dd90e4089 ("x86/physdev: enable PH

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Andrew Cooper
On 08/05/2020 13:43, Jan Beulich wrote: > The op has a register/unregister flag, and hence registration shouldn't > happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle > this case. > > Fixes: eb3dd90e4089 ("x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for > PVH Dom0") > Si

[PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Jan Beulich
The op has a register/unregister flag, and hence registration shouldn't happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle this case. Fixes: eb3dd90e4089 ("x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/io.