Re: [PATCH] x86/PV: assert page state in mark_pv_pt_pages_rdonly()

2021-08-17 Thread Jan Beulich
On 17.08.2021 12:30, Andrew Cooper wrote: > On 17/08/2021 09:54, Jan Beulich wrote: >> On 16.08.2021 21:25, Andrew Cooper wrote: >>> On 16/08/2021 16:29, Jan Beulich wrote: and an apparently wrong comment stating that not only v_end but also v_start would be superpage aligned >>> Which co

Re: [PATCH] x86/PV: assert page state in mark_pv_pt_pages_rdonly()

2021-08-17 Thread Andrew Cooper
On 17/08/2021 09:54, Jan Beulich wrote: > On 16.08.2021 21:25, Andrew Cooper wrote: >> On 16/08/2021 16:29, Jan Beulich wrote: >>> About every time I look at dom0_construct_pv()'s "calculation" of >>> nr_pt_pages I question (myself) whether the result is precise or merely >>> an upper bound. I thin

Re: [PATCH] x86/PV: assert page state in mark_pv_pt_pages_rdonly()

2021-08-17 Thread Jan Beulich
On 16.08.2021 21:25, Andrew Cooper wrote: > On 16/08/2021 16:29, Jan Beulich wrote: >> About every time I look at dom0_construct_pv()'s "calculation" of >> nr_pt_pages I question (myself) whether the result is precise or merely >> an upper bound. I think it is meant to be precise, but I think we wo

Re: [PATCH] x86/PV: assert page state in mark_pv_pt_pages_rdonly()

2021-08-16 Thread Andrew Cooper
On 16/08/2021 16:29, Jan Beulich wrote: > About every time I look at dom0_construct_pv()'s "calculation" of > nr_pt_pages I question (myself) whether the result is precise or merely > an upper bound. I think it is meant to be precise, but I think we would > be better off having some checking in pla

[PATCH] x86/PV: assert page state in mark_pv_pt_pages_rdonly()

2021-08-16 Thread Jan Beulich
About every time I look at dom0_construct_pv()'s "calculation" of nr_pt_pages I question (myself) whether the result is precise or merely an upper bound. I think it is meant to be precise, but I think we would be better off having some checking in place. Hence add ASSERT()s to verify that - all pag