Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Alejandro Vallejo
On Tue, Dec 10, 2024 at 4:14 PM Jan Beulich wrote: > > On 10.12.2024 16:12, Alejandro Vallejo wrote: > > On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote: > >> On 10.12.2024 15:25, Alejandro Vallejo wrote: > >>> On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: > Fields of anonymous

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Jan Beulich
On 10.12.2024 16:12, Alejandro Vallejo wrote: > On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote: >> On 10.12.2024 15:25, Alejandro Vallejo wrote: >>> On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: Fields of anonymous structs/unions may not be part of an initializer for rather

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Alejandro Vallejo
On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote: > On 10.12.2024 15:25, Alejandro Vallejo wrote: > > On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: > >> Fields of anonymous structs/unions may not be part of an initializer for > >> rather old gcc. > > > > Can you add the specific versi

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Jan Beulich
On 10.12.2024 15:25, Alejandro Vallejo wrote: > On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: >> Fields of anonymous structs/unions may not be part of an initializer for >> rather old gcc. > > Can you add the specific version for tracking purposes? It's all the same as before, and I reall

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: > Fields of anonymous structs/unions may not be part of an initializer for > rather old gcc. Can you add the specific version for tracking purposes? > > Fixes: 49a068471d77 ("x86/fpu: Rework fpu_setup_fpu() uses to split it in > two") > Signe

[PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-09 Thread Jan Beulich
Fields of anonymous structs/unions may not be part of an initializer for rather old gcc. Fixes: 49a068471d77 ("x86/fpu: Rework fpu_setup_fpu() uses to split it in two") Signed-off-by: Jan Beulich --- a/xen/arch/x86/i387.c +++ b/xen/arch/x86/i387.c @@ -306,13 +306,13 @@ void vcpu_reset_fpu(struct