Re: [PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn

2023-01-29 Thread Juergen Gross
On 27.01.23 19:55, Julien Grall wrote: From: Julien Grall The parameters of hashfn/eqfn should never be modified. So constify them and propagate the const to the users. Take the opportunity to solve some coding style issues around the code modified. Signed-off-by: Julien Grall Reviewed-by:

RE: [PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn

2023-01-27 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: [PATCH] tools/xenstored: hashtable: Constify the parameters of > hashfn/eqfn > > From: Julien Grall > > The parameters of hashfn/eqfn should never be modified. So constify > them and propagate the const to the users. &

[PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn

2023-01-27 Thread Julien Grall
From: Julien Grall The parameters of hashfn/eqfn should never be modified. So constify them and propagate the const to the users. Take the opportunity to solve some coding style issues around the code modified. Signed-off-by: Julien Grall --- tools/xenstore/hashtable.c| 16 ---