Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

2023-06-09 Thread Christian Lindig
> On 9 Jun 2023, at 10:37, Andrew Cooper wrote: > > On 09/06/2023 9:17 am, Christian Lindig wrote: >>> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: >>> >>> +type arm_physinfo_caps = >>> + { >>> +sve_vl: int; >>> + } >>> + >> >> Does the OCaml side need to know about the structure of

Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

2023-06-09 Thread Andrew Cooper
On 09/06/2023 9:17 am, Christian Lindig wrote: >> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: >> >> +type arm_physinfo_caps = >> + { >> +sve_vl: int; >> + } >> + > > Does the OCaml side need to know about the structure of this value or is it > enough to pass it around as an abstract value

Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

2023-06-09 Thread Christian Lindig
> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: > > +type arm_physinfo_caps = > + { > +sve_vl: int; > + } > + Does the OCaml side need to know about the structure of this value or is it enough to pass it around as an abstract value because all logic is on the C side? I assume the OCa

Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

2023-06-08 Thread Luca Fancellu
> On 8 Jun 2023, at 20:33, Andrew Cooper wrote: > > The original change doesn't compile on ARM: > > xenctrl_stubs.c: In function 'stub_xc_physinfo': > xenctrl_stubs.c:821:16: error: unused variable 'arch_cap_flags_tag' > [-Werror=unused-variable] >821 | int r, arch_cap_flags_tag

[PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

2023-06-08 Thread Andrew Cooper
The original change doesn't compile on ARM: xenctrl_stubs.c: In function 'stub_xc_physinfo': xenctrl_stubs.c:821:16: error: unused variable 'arch_cap_flags_tag' [-Werror=unused-variable] 821 | int r, arch_cap_flags_tag; |^~ cc1: all warnin