Re: [PATCH] tools/misc: fix xenwatchdogd invocation

2024-03-26 Thread Jan Beulich
On 26.03.2024 06:15, zithro / Cyril Rébert wrote: > --- a/tools/misc/xenwatchdogd.c > +++ b/tools/misc/xenwatchdogd.c > @@ -8,26 +8,34 @@ > #include > #include > #include > +#include > #include > > +#define _GNU_SOURCE This wants defining first thing in a file (or even on the compiler c

[PATCH] tools/misc: fix xenwatchdogd invocation

2024-03-25 Thread zithro / Cyril Rébert
When xenwatchdogd is invoked with -h/--help (or any non-number), the argument value is converted to 0, which immediately shutdowns dom0. So make sure only numbers are passed to the program, otherwise fail. For the help, use getopt_long as suggested. While there, reformat the code a bit (s/tabs/spa