Re: [PATCH] tools/libxc: Drop copy-in in xc_physinfo()

2022-01-05 Thread Anthony PERARD
On Thu, Dec 23, 2021 at 04:22:44PM +, Andrew Cooper wrote: > The first thing XEN_SYSCTL_physinfo does is zero op->u.physinfo. > > Do not copy-in. It's pointless, and most callers don't initialise their > xc_physinfo_t buffer to begin with. Remove the pointless zeroing from the > remaining ca

RE: [PATCH] tools/libxc: Drop copy-in in xc_physinfo()

2021-12-28 Thread Wei Chen
Hi Andrew, > -Original Message- > From: Xen-devel On Behalf Of > Andrew Cooper > Sent: 2021年12月24日 0:23 > To: Xen-devel > Cc: Andrew Cooper ; Anthony PERARD > ; Juergen Gross > Subject: [PATCH] tools/libxc: Drop copy-in in xc_physinfo() > > The first thi

[PATCH] tools/libxc: Drop copy-in in xc_physinfo()

2021-12-23 Thread Andrew Cooper
The first thing XEN_SYSCTL_physinfo does is zero op->u.physinfo. Do not copy-in. It's pointless, and most callers don't initialise their xc_physinfo_t buffer to begin with. Remove the pointless zeroing from the remaining callers. Spotted by Coverity. Signed-off-by: Andrew Cooper --- CC: Antho