Re: [PATCH] tools/libs/light: fix race in Makefile

2020-10-26 Thread Jan Beulich
On 26.10.2020 10:46, Jürgen Groß wrote: > On 26.10.20 10:34, Jan Beulich wrote: >> What I don't understand here is why this two step moving around of >> headers is used: Instead of the above pattern rule, can't the rule >> to generate _libxl_type%.h, _libxl_type%_json.h, >> _libxl_type%_private.h,

Re: [PATCH] tools/libs/light: fix race in Makefile

2020-10-26 Thread Jürgen Groß
On 26.10.20 10:34, Jan Beulich wrote: On 25.10.2020 11:12, Juergen Gross wrote: The header $(INCLUDE)/_lixl_list.h matches two different rules, which can result in build breakage. Fix that. While I don't doubt you having observed a race, I'm not sure this is true, and hence I'm also not sure t

Re: [PATCH] tools/libs/light: fix race in Makefile

2020-10-26 Thread Jan Beulich
On 25.10.2020 11:12, Juergen Gross wrote: > The header $(INCLUDE)/_lixl_list.h matches two different rules, which > can result in build breakage. Fix that. While I don't doubt you having observed a race, I'm not sure this is true, and hence I'm also not sure the change is going to address it: Aiui

[PATCH] tools/libs/light: fix race in Makefile

2020-10-25 Thread Juergen Gross
The header $(INCLUDE)/_lixl_list.h matches two different rules, which can result in build breakage. Fix that. Signed-off-by: Juergen Gross --- tools/libs/light/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile